[PHP7] Warning: count(): Parameter must be an array or an object that implements Countable in PHP 7.2 [#2932916]

相关文章推荐

拉风的保温杯 · php如何获取上一个月的今天的上一天的日期- ...· 2 月前 ·

爱跑步的感冒药 · sqlsrv_fetch_array - ...· 1 周前 ·

私奔的领结 · 【PHP】sign加签方法示例_php sign· 5 天前 ·

阳刚的凉面 · 新闻中心_常州百康特医疗器械有限公司· 8 月前 ·

瘦瘦的打火机 · 李锴锴老师《Nature ...· 1 年前 ·

谈吐大方的水龙头 · spi的波特率和时钟的关系_h70 spi ...· 1 年前 ·

刚毅的炒面 · 国家税务总局宁夏回族自治区税务局 ...· 1 年前 ·

健壮的山寨机 · voc t10plus管理密码怎么-抖音· 1 年前 ·

Drupal 7 will officially reach its End of Life on 5 January 2025. This date marks the 14-year anniversary since Drupal 7 was released on 5 January 2011. It is recommended to migrate your site as soon as possible.

Closed (duplicate)

Project:

Drupal core

Version:

8.4.x-dev

Component:

base system

Priority:

Normal

Category:

Bug report

Assigned:

Unassigned

Issue tags:

PHP 7.0 (duplicate)

PHP 7.2 about tags

PHP 7.2: The issue particularly affects sites running on PHP version 7.2.0 or later.

Reporter:

mh35

Created:

25 Dec 2017 at 09:14 UTC

Updated:

25 Feb 2018 at 20:44 UTC

Jump to comment: Most recent , Most recent file

While install Drupal 8.4.3 in PHP 7.2 environment, this warning is occurred.

Warning: count(): Parameter must be an array or an object that implements Countable in Drupal\Core\Form\FormValidator->doValidateForm() (line 260 of core/lib/Drupal/Core/Form/FormValidator.php). Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 239) Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 239) Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 239) Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'install_configure_form') (Line: 119) Drupal\Core\Form\FormValidator->validateForm('install_configure_form', Array, Object) (Line: 571) Drupal\Core\Form\FormBuilder->processForm('install_configure_form', Array, Object) (Line: 314) Drupal\Core\Form\FormBuilder->buildForm('install_configure_form', Object) (Line: 899) install_get_form('Drupal\Core\Installer\Form\SiteConfigureForm', Array) (Line: 593) install_run_task(Array, Array) (Line: 549) install_run_tasks(Array) (Line: 117) install_drupal(Object) (Line: 44) CommentFileSizeAuthor #7 count-warnings-php72-2932916-7.patch 6.82 KB oriol_e9g

7.x:
PHP 7 & MySQL 5.5 2,033 pass, 5 fail

Comment #2

tibezh Credit Attribution: tibezh at OPTASY , Drupal Ukraine Community commented 25 December 2017 at 14:21

Seems this issue is duplicated

Look at #2928846: [PHP 7.2] count() parameter must be an array or an object that implements Countable

Well, although related, I don't think it's a duplicate and the other issue was fixed and was for some tests.

This happened for me as well and it's on the actual code, not tests. I still think is valid.

install

PHP 7.0 (duplicate)

PHP 7.2

#2925449: [PHP 7] Function each() is deprecated since PHP 7.2 [D7]

Related conversion

The issue is relevant and it affects D 7.x too. After updating to PHP 7.2 I get a warning on clean D7 install:

Warning: count(): Parameter must be an array or an object that implements Countable in _form_validate() (line 1441 of /var/www/docroot/web/includes/form.inc).

The last submitted patch, 7: count-warnings-php72-2932916-7.patch , failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

#2928846: [PHP 7.2] count() parameter must be an array or an object that implements Countable

#2915820: [PHP 7.2] FormValidator: Parameter must be an array or an object that implements Countable

#2885610: [PHP 7.2] Avoid count() calls on uncountable variables

For Drupal 7 there is already an issue for this at #2885610: [PHP 7.2] Avoid count() calls on uncountable variables - let's combine work over there.

For Drupal 8, it's a duplicate also, but the wrong issue was linked to above. #2915820: [PHP 7.2] FormValidator: Parameter must be an array or an object that implements Countable is the actual issue where the error described in the issue summary was fixed in 8.5.x. It looks like a decision was made there not to backport to 8.4.x.

Comment #10

joseph.olstad

French

Credit Attribution: joseph.olstad

25 February 2018 at 19:03

patch at #2885610: [PHP 7.2] Avoid count() calls on uncountable variables
looks like it is good, what would we need from#7 several errors?

also, regarding #7

is_array by it'self is costly, see
#2863786: D7 ThemeRegistry array_key_exists() micro-optimization
#2770065: array_key_exists() micro-optimization

Comment #11

joseph.olstad

French

Credit Attribution: joseph.olstad

25 February 2018 at 22:37

I reviewed patch #7 , ~~I don't recommend we take anything from this.~~ have not yet determined if there is anything we can take from this patch
query condition is already countable, does not throw warnings. D7 condition is implemented in a similar way to D8 and D8 uses count() for this. I checked the 8.6.x branch code on this and compared with 7.x and looked at the various query classes and interfaces and implements interface, not only that, I don't see any mention of this actually happening in the wild.

I am curious now to try combining
#2885610: [PHP 7.2] Avoid count() calls on uncountable variables
#2925449: [PHP 7] Function each() is deprecated since PHP 7.2 [D7]

and see if the php 7.2 tests will pass. **UPDATE** php 7.2 only one fail, see issue below.
I have opened a new issue for that (combining the two patches).
#2947772: Fully support PHP 7.2 in Drupal 7

Log in or register to post comments
#2915820: [PHP 7.2] FormValidator: Parameter must be an array or an object that implements Countable #2925449: [PHP 7] Function each() is deprecated since PHP 7.2 [D7] #2885610: [PHP 7.2] Avoid count() calls on uncountable variables